Fix unpacking vendors not performing area entry #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the third (fourth?) time someone has put up a PR to fix this. This one will beat the curse I believe. LGTM |
|
an issue i see with this is that if you say pocket an item then put it on the ground repeatedly, it'll repeatedly "Enter" the area without ever exiting it i think the same change should be made further up in the exit check to stay consistent |
harryob
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes unboxing vendors not entering the area to try and connect to the powernet. Note - this will mean all items getting picked up and dropped are now entering/exiting areas correctly. Possible there's some obscure new behavior with this but its unlikely.
Explain why it's good for the game
If you unbox a machine in a powered area, it should be powered.
Testing Photographs and Procedure
Screenshots & Videos
power.mp4
Changelog
🆑 Drathek
fix: Fixed unboxed machines not connecting to the power net
/:cl: