Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ARES: Synthetic Sparker #6120

Closed

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Apr 8, 2024

About the pull request

Adds a 3 use (rechargable) defib that only works on synthetics, usable by people trained in engineering.

Explain why it's good for the game

While I haven't really thought about how this will be accessible, I find it quite common that people with engineering skills repair synths, but they're unable to find anyone with a medical defib in order to reactivate the synthetic. This would make it possible for them to reactive a synth on their own. I may change it from 3 use per charge to 1 use, subject to balance review.

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Added the Synthetic Sparker, an engineering skill defib that only works on Synthetics.
imageadd: Temporary sprites.
code: Changed how defibs handle who can use them, adding variables for skill checks.
/:cl:

ToDo

  • Sprites
  • Make Craftable?
  • Determine availability.

@realforest2001 realforest2001 added this to the Project ARES milestone Apr 8, 2024
@github-actions github-actions bot added the Feature Feature coder badge label Apr 8, 2024
@realforest2001 realforest2001 added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Apr 8, 2024
@realforest2001 realforest2001 marked this pull request as draft April 11, 2024 10:15
@github-actions github-actions bot added the Code Improvement Make the code longer label Apr 20, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 28, 2024
@github-actions github-actions bot added the Sprites Remove the soul from the game. label May 8, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels May 14, 2024
@harryob harryob removed the Stale Exempt PR can't go stale label Jul 9, 2024
@harryob
Copy link
Member

harryob commented Jul 9, 2024

re-open when ready for review

@harryob harryob closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants