Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional cryo reagent duplication via TOUCH reaction #6122

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Apr 8, 2024

About the pull request

This PR is a follow up to #6058 where it was brought to my attention that chemicals were still duplicating from cryotube beakers. This is because the cryotube was trying to simulate the patient being immersed in the reagents, but with a 50% permeability that doesn't even consume the reacted reagents, it easily gets out of control if large volumes are involved and or the ratio of cryo meds is small in the mixture causing frequent reapplications of reagents.

Explain why it's good for the game

It was intended to remove chemical duplication via cyropods. This shores up another source of chemical duplication.

Testing Photographs and Procedure

Screenshots & Videos

cryo

After rework 200 bicaradine and 20 cryoxadone:

image

Changelog

🆑 Drathek
fix: Fixed cryotubes still duplicating chemicals because of touch reactions
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Apr 8, 2024
@fira
Copy link
Member

fira commented Apr 10, 2024

if the issue is the duplication of reagents, couldn't this be disabled in reaction() instead to maintain per-chemical touch interactions?

@Drulikar
Copy link
Contributor Author

if the issue is the duplication of reagents, couldn't this be disabled in reaction() instead to maintain per-chemical touch interactions?

See https://github.com/cmss13-devs/cmss13/blob/master/code/modules/reagents/Chemistry-Reagents.dm#L95-L116

If the reaction is touch, and user has no biosuit, 50% is duplicated into the mob. The reaction itself probably should change such that whatever enters the mob is deleted from holder, but I have no idea the implications what all that may do; it also just makes rationing what is applied to the mob difficult.

@Drulikar
Copy link
Contributor Author

Let me know if you prefer that.

@Drulikar Drulikar marked this pull request as draft April 11, 2024 09:27
@Drulikar Drulikar marked this pull request as ready for review April 11, 2024 10:35
@harryob harryob added this pull request to the merge queue Apr 12, 2024
Merged via the queue into cmss13-devs:master with commit 1a6e4d8 Apr 12, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 12, 2024
@Drulikar Drulikar deleted the Fix_Cryotube_Duping branch April 12, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants