Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an upgraded photocopier for the CL and CC #6126

Merged
merged 26 commits into from
Apr 21, 2024

Conversation

LC4492
Copy link
Contributor

@LC4492 LC4492 commented Apr 9, 2024

About the pull request

Adds a new photocopier with a higher toner level (180) and that also have a higher print-at-once max limit (from the original 10 to 30), the original photocopier have been maintained for most part of the ship, receiving a little boost on the toner level (from the original 30 to 45).
Sprites in overall have been updated to have a little bit more charm and look better, but the new photocopier version have a new "Weyland-Yutani" paint-scheme (look at the objects' descriptions for reason).

Explain why it's good for the game

One problem that everyone encounters at least one time playing as CC or CL is the fact that, the toner limit of the normal photocopier is an annoying nightmare: Printing photos take a LOT of toner, and even though that makes a good balancing for the normal photocopier, its a giant ROCK in the way of anyone who wishes to mass-print newspapers (as CC) or spread pamphlets and photos (as CL) for the crew. This change would possibly makes the lives of both roles MUCH easier when printing and distributing, papers and photos, in mass.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Adds a new, better variation of the normal photocopier.
imageadd: Adds a new sprite to the new photocopier variation and updates the sprites of both normal, and new photocopiers to look slightly better.
maptweak: Adds the new photocopiers to the CC and CL offices.
/:cl:

@LC4492 LC4492 requested a review from Nanu308 as a code owner April 9, 2024 18:07
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Feature Feature coder badge labels Apr 9, 2024
fira
fira previously requested changes Apr 10, 2024
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good sprites

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Apr 12, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address fira's reviews

@harryob harryob marked this pull request as draft April 13, 2024 09:59
@LC4492
Copy link
Contributor Author

LC4492 commented Apr 14, 2024

Removed everything I could without disrupting the normal functions of the photocopier.

@LC4492 LC4492 marked this pull request as ready for review April 14, 2024 16:34
@LC4492 LC4492 requested a review from fira April 14, 2024 16:34
@Drulikar Drulikar marked this pull request as draft April 19, 2024 21:37
@LC4492 LC4492 marked this pull request as ready for review April 19, 2024 23:58
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar added the Mapping Approved adds 500 new dict keys label Apr 20, 2024
@Drulikar Drulikar marked this pull request as draft April 20, 2024 03:25
@LC4492 LC4492 marked this pull request as ready for review April 21, 2024 20:16
code/modules/paperwork/photocopier.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar enabled auto-merge April 21, 2024 21:13
@Drulikar Drulikar added this pull request to the merge queue Apr 21, 2024
Merged via the queue into cmss13-devs:master with commit 85bcc1a Apr 21, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants