Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SOs to perform basic surgeries #6136

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

567Turtle
Copy link
Contributor

@567Turtle 567Turtle commented Apr 11, 2024

About the pull request

gives so surgery 1

Explain why it's good for the game

> give SO surgery tools
> dont give them the capability to use them

It was probably an over sight but despite having the tools to do surgery SOs don't know how. They aren't able to properly fulfill their role as medics in a time of crisis.

Screenshots & Videos

i didnt test this at all lol, probably works

Changelog

🆑
balance: SO can now do basic surgeries
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Apr 11, 2024
@Git-Nivrak
Copy link
Contributor

Balance, not add in CL

@HeresKozmos
Copy link
Contributor

This seems somewhat pointless and unneeded.

@567Turtle
Copy link
Contributor Author

567Turtle commented Apr 11, 2024

This seems somewhat pointless and unneeded.

Currently as an SO it's neigh impossible to act as a corpsman, because you have to go and find an actual corpsman anytime you get a patient with IB. Which is a lot. IB is very common.

@MobiusWon
Copy link
Contributor

This seems somewhat pointless and unneeded.

Currently as an SO it's neigh impossible to act as a corpsman, because you have to go and find an actual corpsman anytime you get a patient with IB. Which is a lot. IB is very common.

It is neigh impossible because SOs are not medics, they are leaders.

@ihatethisengine
Copy link
Contributor

Should mention that this skill level only let them cure IB and suture, just like your regular medic

@567Turtle
Copy link
Contributor Author

It is neigh impossible because SOs are not medics, they are leaders.

They're meant to be capable of being effective medics you GOOBER... Giving them a surgery kit and then not giving them surgery skill is like giving them the engineering kit but no engineering skill.

@morrowwolf
Copy link
Member

morrowwolf commented Apr 12, 2024

Just from a design perspective pretty much everyone with medic level skills are supposed to be able to do surgery 1. That being said, the question of whether or not SOs should have medical skills and the "skill bloat" of higher ranked roles are both questions that should be hammered down design-wise before any movement is made one way or the other.

If you're just looking for consistency with current game patterns this is a good PR.

If you're looking for a sustainable and consistent design then more thought should be put into this and why auxiliary roles have such high level skills across the board.

Personally, I feel the skill bloat incentivizes "one man army" mindsets and gives up the chance at pushing teamwork incentives via game systems.

As a last note, just because something currently works in certain ways in game does not mean that it should work in game the way it does. The explanation for why it is good for the game should be far broader in scope than it is and the reason that box exists in the first place is to promote thinking about the "big picture" with changes. When someone writes something very basic in that box it makes on lookers question if you really did think about this change in any meaningful way.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 20, 2024
@Drulikar Drulikar added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Feature Feature coder badge labels Apr 20, 2024
@Drulikar Drulikar added this pull request to the merge queue Apr 20, 2024
@Drulikar Drulikar removed this pull request from the merge queue due to a manual request Apr 20, 2024
@Drulikar Drulikar changed the title SO's if they were cool: Allow SOs to perform basic surgeries Apr 20, 2024
@Drulikar Drulikar added this pull request to the merge queue Apr 20, 2024
Merged via the queue into cmss13-devs:master with commit 1c72aa2 Apr 20, 2024
29 checks passed
cm13-github added a commit that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants