Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ARES: Lockdown System #6173

Merged
merged 13 commits into from
May 1, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Apr 20, 2024

About the pull request

Changes the AI Core lockdown to the same system as the Research Containment Lockdown, with all the bells and whistles.
Will likely change it to be more modular :soonTM: rather than duplicating some parts of code.

I also added (again I think? I'm sure I added them before) directional sprites from Thwomper for the wall blended black shutters.

Explain why it's good for the game

The AI Core Lockdown is currently too easy to toggle on-off-on-off. This makes it a bit more meaningful, and thematic.

Testing Photographs and Procedure

All systems nominal!

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Changed the AI Core Lockdown to the same system as Research Lockdown.
add: Added a subtype of desk bell for the AI Core reception desk that sends an alert over APOLLO Link.
imageadd: Added directional blast door sprites from Thwomper for blended black shutters.
code: Renamed operator var in apollo console code to user.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Feature Feature coder badge labels Apr 20, 2024
@realforest2001 realforest2001 added this to the Project ARES milestone Apr 20, 2024
code/game/machinery/aicore_lockdown.dm Show resolved Hide resolved
code/game/machinery/aicore_lockdown.dm Outdated Show resolved Hide resolved
code/__DEFINES/ARES.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_procs.dm Outdated Show resolved Hide resolved
code/game/machinery/aicore_lockdown.dm Outdated Show resolved Hide resolved
code/game/machinery/aicore_lockdown.dm Outdated Show resolved Hide resolved
code/game/machinery/aicore_lockdown.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added UI deletes nanoui/html Code Improvement Make the code longer labels Apr 24, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to add it to the interfaces, then you should do your remote interface as well:
image

@Drulikar Drulikar marked this pull request as draft April 25, 2024 05:09
@realforest2001 realforest2001 marked this pull request as ready for review April 28, 2024 14:30
@realforest2001
Copy link
Member Author

Unsure as of yet if I want it in the admin panel, only because there's already an event limited proc to use it remotely, whereas all staff have access to the interface.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if they can use the vents they should be able to use the doors, but shrugs.

code/game/machinery/biohazard_lockdown.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar enabled auto-merge May 1, 2024 07:25
@Drulikar Drulikar added this pull request to the merge queue May 1, 2024
Merged via the queue into cmss13-devs:master with commit 6d78d51 May 1, 2024
26 checks passed
cm13-github added a commit that referenced this pull request May 1, 2024
@realforest2001 realforest2001 deleted the project/ares/lockdown branch May 10, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge Mapping did you remember to save in tgm format? Sprites Remove the soul from the game. UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants