Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Bleeding Sealing in Cryo Tubes #6175

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Apr 21, 2024

About the pull request

This PR is sort of a follow up to #6058 expanding on the bleeding stop effect for cryotubes allowing them to also seal external bleeding.

Since internal bleeding did not cap the reduction in blood loss, it could underflow resulting in blood being added for the last tick. This is now fixed.

Explain why it's good for the game

Cryotubes already cure IB when cryo chemicals are used because of the patient reaching low temperatures, so I see little reason why the effect wouldn't also occur for external bleeding if you're in a cryotube.

Testing Photographs and Procedure

Screenshots & Videos
bleeding.mp4

Changelog

🆑
balance: Cryotubes now also cure external bleeding
fix: Fixed internal bleeding granting blood on its last tick
/:cl:

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 21, 2024
@Drulikar Drulikar marked this pull request as ready for review April 21, 2024 00:46
@github-actions github-actions bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more labels Apr 21, 2024
@Zonespace27 Zonespace27 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into cmss13-devs:master with commit da476e7 Apr 22, 2024
29 checks passed
cm13-github added a commit that referenced this pull request Apr 22, 2024
@Drulikar Drulikar deleted the Cryo_Tube_External_Bleeding branch April 22, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants