Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugger deletion checking in drone tutorial #6179

Merged

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Apr 22, 2024

About the pull request

This PR is sort of a follow up to #6140 since it became obvious you could soft-lock yourself in the hugger portion of the tutorial. Rather than add more checks to prevent huggers deleting in tutorial, I instead implemented handling when the hugger does die so you can still acquire another hugger. The 30s deletion timer is still disabled for tutorial huggers, but jump attempt deaths are possible.

Explain why it's good for the game

Better replicates the hugger behavior in game, though still not 1-1 and allows the tutorial to not be soft locked which could be very confusing for a new player.

Testing Photographs and Procedure

Screenshots & Videos

https://youtu.be/9EBQNe2p4Sw

Changelog

🆑 Drathek
fix: Fixed hugger handling in drone tutorial: Now the hugger dying will put another hugger into the tutorial morpher.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Apr 22, 2024
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryob harryob added this pull request to the merge queue Apr 24, 2024
Merged via the queue into cmss13-devs:master with commit c13a011 Apr 24, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Apr 24, 2024
@Drulikar Drulikar deleted the Tweak_Huggers_In_Drone_Tutorial branch April 24, 2024 20:04
@Zonespace27 Zonespace27 added this to the Tutorials milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants