Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command announcements for survivors #6192

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Apr 25, 2024

About the pull request

Allows survivors to view tacmap and hear command announcements once they get IFF and marine headsets.

Explain why it's good for the game

When you redeploy as a survivor (which is what you do 90% of the time) it is extremely painful to play without knowing what's going on, no announcements, no tacmap no anything. It is also makes sense that you will have access to those once temporarily enlisting with the marines and having the proper equipment.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Survivors can now receive command announcements with IFF and a marine headset.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Apr 25, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently only announcements work.

Tactical map update messages and accessing the marine tacmap do not work.

image
image

Various changes would have to be made for all faction checks throughout minimap.dm. It was kinda intentionally hardcoded to marine/normal hive. But look at uses of FACTION_MARINE in that file and consider if they aren't either marine or normal hive to check their IFF tag is marine, and if so consider their faction marine in that case.

The act for if("selectAnnouncement") is also where that tactical map update in progress message would get sent.

code/modules/mob/living/carbon/human/human.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft April 26, 2024 00:41
@Git-Nivrak
Copy link
Contributor Author

Going to atomize this to only announcements
There appears to be more to the tacmap than just changing the faction checks and so I will rather deal with at a different time

@Git-Nivrak Git-Nivrak marked this pull request as ready for review April 27, 2024 17:06
@Drulikar Drulikar changed the title Tacmap and command announcements for survivors Command announcements for survivors May 1, 2024
@Drulikar Drulikar added this pull request to the merge queue May 1, 2024
Merged via the queue into cmss13-devs:master with commit aedf6a9 May 1, 2024
29 checks passed
cm13-github added a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants