Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metal sheet exploit fix #6209

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

kiVts
Copy link
Contributor

@kiVts kiVts commented Apr 29, 2024

About the pull request

funny thing I noticed while surfing the code

Explain why it's good for the game

Im pretty sure thats not how world works

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 kivts
fix: Infinite metal oversight fix.
/:cl:

@kiVts kiVts marked this pull request as ready for review April 29, 2024 02:14
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Apr 29, 2024
@kiVts
Copy link
Contributor Author

kiVts commented Apr 30, 2024

print table parts in autolathe > click with wood, this gives one metal sheet for "replacing metal parts with wood" > feed the wood parts into autolathe = +1 net positive on metal.

@Diegoflores31
Copy link
Contributor

print table parts in autolathe > click with wood, this gives one metal sheet for "replacing metal parts with wood" > feed the wood parts into autolathe = +1 net positive on metal.

not exactly "infinite metal" rather an oversight of inheritance

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not
matter = list("wood" = 2000)
Or whatever amount it ought to be?

code/modules/projectiles/gun_attachables.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar enabled auto-merge May 3, 2024 04:19
@Drulikar Drulikar added this pull request to the merge queue May 3, 2024
Merged via the queue into cmss13-devs:master with commit 3d28974 May 3, 2024
26 checks passed
cm13-github added a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants