Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookcases can now be deconstructed by slashing or wrenching #6213

Merged
merged 12 commits into from
May 3, 2024
Merged

Bookcases can now be deconstructed by slashing or wrenching #6213

merged 12 commits into from
May 3, 2024

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Apr 29, 2024 •
edited by github-actions bot
Loading

About the pull request

title

Explain why it's good for the game

no more stupid undestroyable crap blocking your movement

Testing Photographs and Procedure

2024-04-29.15-08-27.mp4

Changelog

🆑
qol: Bookcases can now be wrenched or slashed to be deconstructed
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Apr 29, 2024
Drulikar
Drulikar requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add \improper to the bookshelf names or uncapitalize them.

code/game/objects/structures/bookcase.dm Outdated Show resolved Hide resolved
code/game/objects/structures/bookcase.dm Outdated Show resolved Hide resolved
code/game/objects/structures/bookcase.dm Outdated Show resolved Hide resolved
code/game/objects/structures/bookcase.dm Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft May 3, 2024 05:22
@iloveloopers iloveloopers marked this pull request as ready for review May 3, 2024 05:39
@iloveloopers
Copy link
Contributor Author

alright now its ready for real

Drulikar
Drulikar approved these changes May 3, 2024
View reviewed changes
code/game/objects/structures/bookcase.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar enabled auto-merge May 3, 2024 05:49
@Drulikar Drulikar added this pull request to the merge queue May 3, 2024
Merged via the queue into cmss13-devs:master with commit ab6c09d May 3, 2024
26 checks passed
cm13-github added a commit that referenced this pull request May 3, 2024
@cm13-github
Automatic changelog for PR #6213 [ci skip]
e7f59ee
@iloveloopers iloveloopers deleted the bookcase branch May 7, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fira fira fira left review comments

@Drulikar Drulikar Drulikar approved these changes

Assignees
No one assigned
Labels
Quality of Life Make the game harder to play
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iloveloopers @fira @Drulikar