Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xenos cannot pylon working comms anymore #6241

Merged
merged 5 commits into from
May 11, 2024

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented May 5, 2024

About the pull request

First of all, it looks like a simple oversight. You cannot turn on pyloned comms tower, but for some reason it works the other way around — you can pylon working tower. Don't think this was intended.

Secondly, I think it's a little too boring that you can get both pylon and working comms if you have corrupted xenos. It would be more interesting if you needed to choose between these options.

Explain why it's good for the game

Consistency, balance, important choices.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine
balance: only disabled comms can be pyloned
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label May 5, 2024
@HeresKozmos
Copy link
Contributor

Seems pretty cool.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong, but this is not a repeating call to handle_xeno_acquisition (except if those timers are used below). This is the proc called for the signal COMSIG_WEEDNODE_GROWTH or a re-call using one of the addtimers a little further down. You likely need to in this situation either add a signal for the tower going inoperable, or for you to add a timer to recheck again later.

code/game/machinery/telecomms/presets.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft May 6, 2024 08:19
@ihatethisengine
Copy link
Contributor Author

What about this?

@ihatethisengine ihatethisengine marked this pull request as ready for review May 6, 2024 09:33
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but means that this proc is now very spammable (e.g. toggling the power on and off at the apc). The timers should then be considered unique and allowed to override one another else you can create lots of timers that are redundant:
image

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label May 10, 2024
@Drulikar Drulikar marked this pull request as draft May 10, 2024 07:53
@ihatethisengine ihatethisengine marked this pull request as ready for review May 11, 2024 07:38
@Drulikar Drulikar added this pull request to the merge queue May 11, 2024
Merged via the queue into cmss13-devs:master with commit 78319a2 May 11, 2024
27 checks passed
cm13-github added a commit that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants