Xenos cannot pylon working comms anymore #6241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Balance
|
Seems pretty cool. |
Drulikar
requested changes
May 6, 2024
There was a problem hiding this comment.
I could be wrong, but this is not a repeating call to handle_xeno_acquisition (except if those timers are used below). This is the proc called for the signal COMSIG_WEEDNODE_GROWTH or a re-call using one of the addtimers a little further down. You likely need to in this situation either add a signal for the tower going inoperable, or for you to add a timer to recheck again later.
Co-authored-by: Drathek <[email protected]>
|
What about this? |
Drulikar
requested changes
May 10, 2024
Drulikar
added
the
Balance Approved
Drulikar
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
First of all, it looks like a simple oversight. You cannot turn on pyloned comms tower, but for some reason it works the other way around — you can pylon working tower. Don't think this was intended.
Secondly, I think it's a little too boring that you can get both pylon and working comms if you have corrupted xenos. It would be more interesting if you needed to choose between these options.
Explain why it's good for the game
Consistency, balance, important choices.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 ihatethisengine
balance: only disabled comms can be pyloned
/:cl: