Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mortar shells will now cook off and explode when flamed #6243

Merged
merged 7 commits into from
May 13, 2024

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented May 5, 2024

About the pull request

title

Explain why it's good for the game

immersion. ammo boxes do it, why not shells?
realism (probably)
its gonna be real funny on evac

Testing Photographs and Procedure

shell_fire.mp4

Changelog

🆑
add: Mortar shells will now cook off and explode when flamed
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label May 5, 2024
@vero5123
Copy link
Contributor

You got a runtime buddy.


[2024-05-11 16:40:20.791] Starting up round ID 1
 - -------------------------)
[2024-05-11 16:40:20.814] Running CMSS13 revision: 2024-05-05
 - origin/master: 772d2f31ef35782affc8a6f2be553ca03d864c40
 - HEAD: 22e35ca812931d93912f23e9fb0ac222619f5999
[2024-05-11 17:24:17.210] runtime error: cell_explosion called without cause_data.
 - proc name: stack trace (/proc/stack_trace)
 -   source file: code/__HELPERS/unsorted.dm,1834
 -   usr: (src)
 -   src: null
 -   call stack:
 - stack trace("cell_explosion called without ...")
 - cell explosion(the plating (170,64,3) (/turf/open/floor/plating/almayer), 60, 20, 0, null, null)
 - the 80mm fragmentation mortar ... (/obj/item/mortar_shell/frag): detonate(the plating (170,64,3) (/turf/open/floor/plating/almayer))
 - /datum/callback (/datum/callback): InvokeAsync()
 - 

@Drulikar Drulikar enabled auto-merge May 13, 2024 02:30
@iloveloopers
Copy link
Contributor Author

Man i can never get a perfect one can i?

@Drulikar Drulikar added this pull request to the merge queue May 13, 2024
Merged via the queue into cmss13-devs:master with commit 015a3a6 May 13, 2024
26 checks passed
cm13-github added a commit that referenced this pull request May 13, 2024
@iloveloopers iloveloopers deleted the shellfire branch May 24, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants