-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARC features #6250
ARC features #6250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add: Adds a a pamplet crate containing 1 pamplet for the ARC for 5000$
I am entirely against this.
That was added specifically to go along the ID lock on the ARC . there wont be any ARC hijack or that kind of stuff unless command specifically allows it . also opens grounds for other command/support to drive the ARC under specific circumstances winout having to give every command member a VC skill |
Can you make the key being able to be stored alongside the ID slot or inside the ID? |
@@ -65,7 +65,7 @@ | |||
|
|||
// The amount of skill required to drive the vehicle | |||
var/required_skill = SKILL_VEHICLE_SMALL | |||
|
|||
var/driving_access = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code doc
Here are the issues I see with this:
My opinion isn't changing, please remove the pamphlet from req. Footnotes
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Explain why it's good for the game
-Adds more flexibility to the ARC in cases where there may not be 2 SOs available or they preffer a different driver. to focus more on Commanding inside of the ARC.
-Prevents future funnsies from happening . you now require a Access to drive the ARC meaning . only people granted access by command may drive the ARC. (( can be changed to ACCESS_CREWMAN in the future or even create custom "keys"))
-adds one more passenger to the ARC so marines can retrieve the 3 corpses inside or someone can enter to talk .. etc . the extra slot is meant for a passerby therefore no seat will be added.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: ARC now has a Generic Command access lock for the driver seat
add: Adds a a pamplet crate containing 1 pamplet for the ARC for 5000$
balance: increased ARC capacity to 4
code: Added support for Access locks on Vehicles
/:cl: