Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lets you dig out shrapnel with the throwing knife (+ screwdriver) #6259

Merged
merged 2 commits into from
May 13, 2024

Conversation

neeshacark
Copy link
Contributor

@neeshacark neeshacark commented May 7, 2024

About the pull request

does what it says on the tin, found this to be mildly irritating that you couldn't do it

Explain why it's good for the game

mostly a convenience thing, lets marines eschew the normal bayonet boot knife for a throwable if they prefer without having to carry the bayonet in their webbing or rip the one off their gun every time.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: you can now remove shrapnel from your body with the M11 Throwing Knife and screwdrivers
/:cl:

@neeshacark neeshacark changed the title lets you dig out shrapnel with the throwing knnife lets you dig out shrapnel with the throwing knife May 7, 2024
@github-actions github-actions bot added the Feature Feature coder badge label May 7, 2024
@HumiliatedGoblin
Copy link
Contributor

Can we also use screwdrivers with a bigger chance to cause pain

@realforest2001
Copy link
Member

I would be fine with adding screwdrivers / scalpels to this. Might give CLF a chance to survive.

@neeshacark
Copy link
Contributor Author

I would be fine with adding screwdrivers / scalpels to this. Might give CLF a chance to survive.

if i recall scalpels can already dig shrapnel

i could add screwdrivers but im not a coder, one line changes and mapping related code changes are about all i can do - so the whole more pain thing i could not do

@realforest2001
Copy link
Member

I took a glance through the code and it wouldn't be too difficult to amplify pain for the screwdriver itself, however digging out shrapnel doesn't actually cause real pain, it just makes an emote happen so no need to worry about it.

@HumiliatedGoblin
Copy link
Contributor

digging out shrapnel doesn't actually cause real pain, it just makes an emote happen so no need to worry about it.

I feel like we should definitely give it some sort of downside, same way ghetto surgery does on other codebases and this one. Maybe a longer time, causes bleeding, etc.

@neeshacark neeshacark changed the title lets you dig out shrapnel with the throwing knife lets you dig out shrapnel with the throwing knife (+ screwdriver) May 10, 2024
@neeshacark
Copy link
Contributor Author

I took a glance through the code and it wouldn't be too difficult to amplify pain for the screwdriver itself, however digging out shrapnel doesn't actually cause real pain, it just makes an emote happen so no need to worry about it.

alright, you can do it with screwdrivers now too

@Drulikar Drulikar added this pull request to the merge queue May 13, 2024
Merged via the queue into cmss13-devs:master with commit e03b1ac May 13, 2024
28 checks passed
cm13-github added a commit that referenced this pull request May 13, 2024
@neeshacark neeshacark deleted the throwing-knife-buff branch May 14, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants