Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ARES: Almayer Sentries #6268

Merged
merged 7 commits into from
May 25, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented May 9, 2024

About the pull request

Changes the sprites for the sentry deployment systems aboard the USS Almayer to use a custom floor based holder, rather than a floating wall mount.

Also adds mini sentry deployers, along with an AI-Core subtype that autodeploys on lockdown.

Explain why it's good for the game

Currently the sentry deployment system sprites are designed as if they're mounted to walls, and they usually are, but on the Almayer they're essentially floating next to the fuel pumps. This changes that.

Also it allows the AI Core to be protected from xenos without subjecting non-existant joes to melee combat.

Testing Photographs and Procedure

Screenshots & Videos

image
image

Changelog

🆑
imageadd: added sprites for floor-mounted sentry deployment systems.
add: Added mini-sentry deployment systems, and an AI Core subtype.
/:cl:

@realforest2001 realforest2001 added this to the Project ARES milestone May 9, 2024
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Feature Feature coder badge labels May 9, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They push you off of them when they deploy, but they don't have density:
image

Also kinda minor, but their examine icon is odd:
image

Then again, a regular sentry isn't much better...

image

code/game/machinery/sentry_holder.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar requested a review from a team May 18, 2024 06:13
@Drulikar Drulikar added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. labels May 18, 2024
@Drulikar Drulikar marked this pull request as draft May 18, 2024 07:51
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the colors should be consistent with the rappel hatch

also there should be a deploying animation unless i'm missing something

@realforest2001
Copy link
Member Author

realforest2001 commented May 19, 2024

For animation the current deploy system doesn't use one so I haven't made one. I'd have to animate and delay everything on both systems otherwise.

@realforest2001
Copy link
Member Author

Examine icons I can't do much about, they're kinda borked on just about everything in the game

Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label May 24, 2024
@Drulikar Drulikar added the Mapping Approved adds 500 new dict keys label May 25, 2024
@realforest2001 realforest2001 marked this pull request as ready for review May 25, 2024 12:24
code/game/machinery/sentry_holder.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar enabled auto-merge May 25, 2024 13:33
@Drulikar Drulikar added this pull request to the merge queue May 25, 2024
Merged via the queue into cmss13-devs:master with commit 9d6826c May 25, 2024
27 checks passed
cm13-github added a commit that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants