Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Labeler Workflow Triggers #6272

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented May 10, 2024

About the pull request

This PR simply expands the trigger for the labeler workflow. I would like the workflow to be required, but as is it simply blocked the merge queue when the label was made into a required check.

Changelog

No player facing changes.

@github-actions github-actions bot added Github We don't really know what else this belongs to Missing Changelog Maintainers always document their changes. labels May 10, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one best way to test action prs right

@harryob harryob added this pull request to the merge queue May 14, 2024
Merged via the queue into cmss13-devs:master with commit a0bd9c0 May 14, 2024
28 checks passed
@Drulikar Drulikar deleted the Labeler_Sync branch May 14, 2024 09:48
@Drulikar
Copy link
Contributor Author

Went back to sync method via b7722a3 this won't allow me to make it required, but atleast it should always be listed in checks rather than poofing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github We don't really know what else this belongs to Missing Changelog Maintainers always document their changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants