Allows maintenance jack to be quick drawn #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Quality of Life
Zonespace27
requested changes
May 10, 2024
Zonespace27
previously requested changes
May 10, 2024
Drulikar
requested changes
May 13, 2024
There was a problem hiding this comment.
All overrides to flags_atom need to be looked at.
For example /obj/item/weapon/gun/launcher/rocket can normally go into your suit slot and you can press E to draw it, but since /obj/item/weapon/gun overrides flags_atom it now no longer does so since you need the QUICK_DRAWABLE flag, and it doesn't have it.
You may consider using :: to |= existing flags in definitions; but honestly there aren't that many to fix. The regex to find all weapon definitions in this scenario is probably something like ^/obj/item/weapon/[\w/]*?$((.|\n)(?!^/))*?flags_atom ?=(?!^/)
Drulikar
approved these changes
May 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cm13-github
added a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Allows maintenance jack to be quick drawn as well as adding a flag that allows to replicate this behavior for other items.
Explain why it's good for the game
Quality of life, Requested by a player
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
qol: Maintenance jack can now be quick drawn
code: Added a flag that allows items to be quick draw-able despite not being weapons.
/:cl: