Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verb to adjust predator slots #6289

Merged
merged 1 commit into from
May 23, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented May 15, 2024

About the pull request

This PR fixes the adjust_predator_round admin verb that could never do anything because its max was always set to a value <= 0. Now it can adjust the pred_additional_max value if it doesn't result in a max lower than the current count. However, I expect the pred_current_num to be incorrect if there are say councilors playing since only WHITELIST_NORMAL checks the limit, but only CLAN_RANK_ADMIN (ancient) prevents pred_current_num incrementing... Let me know if & how you would want this corrected.

Explain why it's good for the game

Admin verbs shouldn't just be dead code.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑 Drathek
admin: Fixed the adjust_predator_round verb
/:cl:

@Drulikar Drulikar added the Code Improvement Make the code longer label May 15, 2024
@github-actions github-actions bot added the Admin Make things harder for admins label May 15, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 23, 2024
@harryob harryob added this pull request to the merge queue May 23, 2024
Merged via the queue into cmss13-devs:master with commit cc5d093 May 23, 2024
28 checks passed
cm13-github added a commit that referenced this pull request May 23, 2024
@Drulikar Drulikar deleted the Adjust_Pred_Extra branch May 28, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Code Improvement Make the code longer Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants