Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank Change Experiment #6295

Merged
merged 26 commits into from
Jul 30, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented May 16, 2024

About the pull request

Changes the backend of how paygrades are worked out on equipment presets so we no longer need to override it several times for different roles based on playtime.

Added sub-10 hour ranks for most USCM roles (all enlisted that didn't already have them, and most officers above 2nd LT)
Added 70+ hour ranks for most USCM enlisted and some officers.

Explain why it's good for the game

The hope is that this will make things a little more dynamic, and also help address the clutter we have of certain paygrades (IE the Sergeant SL leading 9 lance corporals and a dozen or more PFCs)
Whilst true, in regards to Squad Rifleman, there can now be MORE lance corporals, the hope is this will be more scattered and accounted for by senior NCOs being slightly more common.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Changed back-end for working out equipment preset paygrades so as to remove the manual overrides on several roles based on playtime perks.
add: Added lower ranks for all enlisted and some officer roles subject to having played for less than ten hours. This rank cannot be used after playing more than ten hours, and ignores preferences for playtime perks.
add: Added a higher rank achievable to most enlisted and some officers, requiring 175+ hours.
add: Changed base rank for SL, SG, Spec and FTL by one grade up.
add: Changed low playtime rank for MP and Nurse from Lance Corporal to Corporal.
/:cl:

@realforest2001 realforest2001 changed the title experiment Rank Change Experiment May 16, 2024
@github-actions github-actions bot added Code Improvement Make the code longer Feature Feature coder badge labels May 16, 2024
cm13-github added a commit that referenced this pull request May 16, 2024
cm13-github added a commit that referenced this pull request May 16, 2024
cm13-github added a commit that referenced this pull request May 16, 2024
One round experiment.
cm13-github added a commit that referenced this pull request May 29, 2024
cm13-github added a commit that referenced this pull request May 29, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 7, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jun 7, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jun 18, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jun 29, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github added a commit that referenced this pull request Jul 22, 2024
@rythenx
Copy link
Contributor

rythenx commented Jul 22, 2024

I'm just a random player but I don't really like the idea of people with more playtime in the same job being able to lawfully order around other people of the same job. I think this makes sense only for absolute beginners in a job, ie. being able to recognize a new rifleman by seeing they are a private is good because it leads to people helping them out. The same benefit doesn't really exist IMO when you are wanting to identify people with 10+ hours compared to people with 70+ hours.

I feel like having certain jobs like CMO be able to be two different ranks is just going to make people more judgemental toward "new" CMOs who don't have the higher rank and be less willing to listen to them. It just feels like it would encourage elitism to me.

Additionally, it seems like in its current state this also leads to weird situations where a CE could be a higher rank than an ASO despite the CE being subordinate to the ASO. Similarly it can result in the ASO and XO being the same rank despite the ASO being subordinate to the XO.

cm13-github added a commit that referenced this pull request Jul 25, 2024
@efzapa
Copy link
Contributor

efzapa commented Jul 25, 2024

I'm just a random player but I don't really like the idea of people with more playtime in the same job being able to lawfully order around other people of the same job. I think this makes sense only for absolute beginners in a job, ie. being able to recognize a new rifleman by seeing they are a private is good because it leads to people helping them out. The same benefit doesn't really exist IMO when you are wanting to identify people with 10+ hours compared to people with 70+ hours.

I feel like having certain jobs like CMO be able to be two different ranks is just going to make people more judgemental toward "new" CMOs who don't have the higher rank and be less willing to listen to them. It just feels like it would encourage elitism to me.

Additionally, it seems like in its current state this also leads to weird situations where a CE could be a higher rank than an ASO despite the CE being subordinate to the ASO. Similarly it can result in the ASO and XO being the same rank despite the ASO being subordinate to the XO.

CMP can now technically get DASO'd if they yell at the CMO which is kinda fucky

cm13-github added a commit that referenced this pull request Jul 27, 2024
cm13-github added a commit that referenced this pull request Jul 28, 2024
@realforest2001
Copy link
Member Author

Y'all keep forgetting that rank is not the be-all end-all in the military. Chain of Command is still a thing.

@realforest2001 realforest2001 marked this pull request as ready for review July 28, 2024 15:20
cm13-github added a commit that referenced this pull request Jul 28, 2024
cm13-github added a commit that referenced this pull request Jul 28, 2024
cm13-github added a commit that referenced this pull request Jul 28, 2024
@rythenx
Copy link
Contributor

rythenx commented Jul 29, 2024

Y'all keep forgetting that rank is not the be-all end-all in the military. Chain of Command is still a thing.

True enough. I was overthinking it and I do like the variety in ranks after seeing it for longer.

@Drulikar Drulikar enabled auto-merge July 30, 2024 19:11
@Drulikar Drulikar added this pull request to the merge queue Jul 30, 2024
Merged via the queue into cmss13-devs:master with commit 30d8f48 Jul 30, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jul 30, 2024
@wgtjunior743
Copy link
Contributor

Besides the corporate liason, there is no JOB_PLAYTIME_TIER_4 new roles.
image

the FTL did not get a rank up, their previous base rank was corporal and they can still be a corporal as base, the only difference is that they can rank up to sgt like the SG and spec.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants