Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter Xeno Evolution: Larva -> Drone Mandatory #6298

Closed
wants to merge 9 commits into from

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented May 16, 2024

About the pull request

This PR focus on making Drone as universal evolving caste, and add new evolution system based on how much evolution points each caste cost, now drone caste cost 30 evolution points, and other T1 castes cost 30 evolution points too. (default 60 evo points needed to evolve to T1, same cost as pre-add)

De-evolving as any T1 caste will bring you back to larva stage.

P.S. person behind this idea was @Steelpoint , i just made this to reality, just work slightly different for balance:
https://forum.cm-ss13.com/t/alter-xeno-evolution-larva-drone-mandatory/8075

Explain why it's good for the game

Allow xenos to evolve quicker to T1 drone caste, this change make new players get used to playing as Xenos (new XX players), additionally it prevent people from missing out on evolution, you got too immersed in building as drone (doing drone tax) and you missed your evolution to T2 at 14 minute? now this will not be issue anymore, now you don't need to de-evolve and evolve again to become other branch of xeno to just get that Warrior or other castes.

Testing Photographs and Procedure

Fully unlocked Evolution choices:
image

Changelog

🆑 Venuska1117
balance: Larva evolve only to Drone, Now Drones are "Basic" Caste, they now can evolve to: Runner, Sentiel, Defender, Queen, Burrower and Carrier.
balance: Evolving from: Larva to drone and drone to other T1 castes cost 30 evolution.
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label May 16, 2024
@Venuska1117 Venuska1117 changed the title Ideaguys got real. Alter Xeno Evolution: Larva -> Drone Mandatory May 16, 2024
@Red-byte3D
Copy link
Contributor

this is a balance change not a code improvement change

@Venuska1117
Copy link
Contributor Author

Venuska1117 commented May 16, 2024

this is a balance change not a code improvement change

woops, sorry let me fix that (in cl)

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label May 16, 2024
@Red-byte3D
Copy link
Contributor

1.) Just because people evolve into drones doesnt mean people will go around weeding.
2.) This effects late game balance as you're still required evo points to evolve from drone....to anything? i dont know how you coded this. so later rounds would get gimped
3.) Bonus evo was already added so people can become a drone and then go any caste they want.

@Venuska1117 Venuska1117 marked this pull request as draft May 16, 2024 21:27
@HeresKozmos
Copy link
Contributor

Finally, a good PR.

@cuberound
Copy link
Contributor

based on the Ideaguys Page you are trying to implement the drone should gain evo when queen is not in oviposition or (better) have separete points for evolving from drone to other t1 and from drone to t2 and make it so that you gain the t1 evo points even with queen out of oviposition

@Red-byte3D
Copy link
Contributor

Red-byte3D commented May 16, 2024

If you make it so its 60 evolution to larva -> to drone, how are you planning on solving the issue of drone to any other tier 1? is it going to be free evolution? That'd be causing time issues on how fast you can join the front if it isnt.

From a marine prespective, you'd be allowing newly born alrvas to make weeds walls and more reinforcements while they wait for the allocated x free evolution (before freely evolving to any other "combat" caste.) which would double the efficiency of any new larva born into the hive, taking away the importance factor of your choice. how do you intend to solve this?

The whole larva > drone > tier 1 > tier 2 > tier 3 time gets way longer considering all this, AND the fact that tier 3's are unlocked at minute 20 which would mean in some cases you wouldnt even be getting tier 3 despite marines having landed, due to some late queen spawns, or maybe when a queen isnt chosen round start so one has to evolve then get on ovi how do you plan on solving that?

The biggest issue with this pr is the fact that its un-required, we already have a perfectly working caste-system that saves evo for people who play drone in the sense of locked evo timers and reserve evolution points

@ihatethisengine
Copy link
Contributor

I'd like to keep my free will to play or not to play drone.

@Steelpoint
Copy link
Contributor

The addition of a forced drone evo should not prevent xenos getting t3s before marines arrive, especially if Drone to T1 combat caste has a lower evo time

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to be approved, I do not want the timing to ultimately change for any caste. So that is to say, the speed to become drone should be the same as it was, and T1s that evolved from T0 are compensated for having to go through T1 twice.

@Drulikar Drulikar removed the Code Improvement Make the code longer label May 17, 2024
@Steelpoint
Copy link
Contributor

I sincearly believe now that the best way to make this change work smoothly, is to make it that once you have evolved past Drone, you can not de-evolve back into a Drone (with exception for support xenos). Basically you have to become a Drone, from Larva, but once you are past being a Drone you return back to being a Larva if you de-evolve.

This very much eliminates all possible forms of abuse that I can think of, and is the most elegant solution to said issues without requiring a massive host of further code changes.

@Venuska1117 Venuska1117 reopened this May 19, 2024
@Venuska1117 Venuska1117 requested a review from Drulikar May 20, 2024 09:26
@Venuska1117
Copy link
Contributor Author

Venuska1117 commented May 20, 2024

I will type list of change here, later i will update PR description (i need go to work soon and don't want to forget):
larva -> drone (cost 30 evo points, recommended wait for 60evo threshold)
drone -> runner, defender and sentinel (require 30 evo points, can be carried from larva to drone stage (if you hit 60 evo threshold))

  • Can evolve to other T1 as drone when queen die, but you cannot evolve to T2
  • De-evolve as runner, defender and sentinel make you larva instead of drone (to prevent abuse)
  • You can now choose how much evolution points evolving to specific caste consume (default is 30), just need type them in [caste].dm as "evolution_cost = (number)"
  • Early evolution give you different warning.

- removed "evolve_without_queen" from drone (With was for testing), it function fine without it, and dont give free evo when queen is off ovi alive/dead.
@Venuska1117 Venuska1117 marked this pull request as ready for review May 20, 2024 21:39
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 1, 2024
@Venuska1117 Venuska1117 marked this pull request as draft June 6, 2024 20:59
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jun 9, 2024
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jun 10, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jun 13, 2024
@Venuska1117 Venuska1117 marked this pull request as ready for review June 20, 2024 23:03
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 28, 2024
@github-actions github-actions bot closed this Jul 8, 2024
@Venuska1117 Venuska1117 deleted the drone-tax branch July 10, 2024 07:46
@Venuska1117 Venuska1117 restored the drone-tax branch July 28, 2024 12:30
@Venuska1117 Venuska1117 deleted the drone-tax branch July 29, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants