Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricts contents of custom loadout weapon boxes #6303

Merged
merged 5 commits into from
May 19, 2024

Conversation

doganesi
Copy link
Contributor

@doganesi doganesi commented May 17, 2024

About the pull request

Adds a can_hold list to the Type 73 storing case, D18-storing boxx, and the M8 cartridge bayonet packaging.

Explain why it's good for the game

Prevents any unintended use of these items, such as storing 3 medium sized items inside of a single medium size slot within a satchel.

Fixing oversights is good.

Testing Photographs and Procedure

Screenshots & Videos

https://streamable.com/8rh75b

Changelog

🆑
fix: Fixed some oversights with custom loadout provided weapon boxes
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label May 17, 2024
@Drulikar Drulikar marked this pull request as draft May 18, 2024 04:48
@Drulikar Drulikar added the Good First PR From small acorns label May 18, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW you don't need to concern yourself with this much nor press it every time. You only need to update with master if master has changes that are relevant to your PR.
image

@Drulikar Drulikar marked this pull request as ready for review May 18, 2024 05:30
@Drulikar Drulikar added this pull request to the merge queue May 19, 2024
Merged via the queue into cmss13-devs:master with commit f6bfe15 May 19, 2024
28 checks passed
cm13-github added a commit that referenced this pull request May 19, 2024
@doganesi doganesi deleted the boxfix branch May 26, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Good First PR From small acorns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants