Cats now have the correct name and description when held and in your bag #6306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
description to the correct info
Drulikar
requested changes
May 18, 2024
There was a problem hiding this comment.
You might also want to implement get_examine_text for a /obj/item/holder If its holding an item, you can just return ..() to use the item implementation. But if a mob, you ought to replicate I think /atom/proc/get_examine_text(mob/user)
Currently the mob holder uses the generic item implementation resulting in the difference here:
Drulikar
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
changes the get_scooped proc so that it now uses the correct name and description when creating a new mob_holder object. This means that mobs will have the correct name and description when held or in a container.
Explain why it's good for the game
saying, "Here's the colony cat, Orion!" and then using the show held item verb, only to show "cat" with the default cat description makes no sense and breaks my immersion.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Nomoresolvalou
fix: fixed cats not specifically defined in code displaying wrong info when held or stored in a container. This should also fix any other mob capable of being picked up that is not defined in code as well.
/:cl: