Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some improper APC placements on Shivas Snowball #6315

Merged
merged 2 commits into from
May 24, 2024

Conversation

Tyranicranger4
Copy link
Contributor

@Tyranicranger4 Tyranicranger4 commented May 20, 2024

About the pull request

Fixes a few APCs that were previously placed on top of indestructible dirt, preventing the APC terminal being accessible, and thus making them impossible to move or repair.

Also changes the area path used by the small North generator room/communications room. This room previously shared the same area pathing as the room on the West side of LZ2, both of which had APCs. Doubling up APCs in one area is a mapping sin and makes resolving any issues with either of the APCs extremely frustrating.

Explain why it's good for the game

Bad object placement is bad (the design is very human).

Testing Photographs and Procedure

Screenshots & Videos This is the room with the area pathing changes:

image

See MapDiffBot for the rest, I don't think it's particularly practical for me to screenshot multiple 1 tile changes.

Changelog

🆑
fix: Fixes improperly placed APCs on Shivas Snowball
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Fix Fix one bug, make ten more labels May 20, 2024
@Tyranicranger4
Copy link
Contributor Author

Tyranicranger4 commented May 23, 2024

One of these gets changed by a nightmare insert. Need to account for that.

@Tyranicranger4 Tyranicranger4 marked this pull request as draft May 23, 2024 03:17
@Tyranicranger4 Tyranicranger4 marked this pull request as ready for review May 23, 2024 03:40
@harryob harryob added the Mapping Approved adds 500 new dict keys label May 24, 2024
@harryob harryob added this pull request to the merge queue May 24, 2024
Merged via the queue into cmss13-devs:master with commit b357f67 May 24, 2024
28 checks passed
cm13-github added a commit that referenced this pull request May 24, 2024
@Tyranicranger4 Tyranicranger4 deleted the EvilAPC branch May 27, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants