Return to client macros for tgsay #6320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a follow up to #6244 effectively reverting the changes ported from tgstation/tgstation#75463
Instead of using the down() proc on the server, we are once again doing the tgsay open via winset on hotkey so it is more responsive. However, to fix the issue with tgsay opening when say another window is focused, it now has an embedded winget for map.focus and thats sent in the payload.
Explain why it's good for the game
Should make tgsay open more responsively again.
This was the reason why I needed to make the change in the first place:
Testing Photographs and Procedure
But now that bug is fixed, and we're opening the old way again!
Changelog
🆑 Drathek
ui: TGSay is now opened the same way it used to for more responsiveness
/:cl: