Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ARES: Print ASRS Log #6333

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented May 25, 2024

About the pull request

Allows the ASRS Audit Log to be printed from the ARES Interface.

Explain why it's good for the game

Many times I've seen CMB request access to the audit log for the purposes of checking on black market activity. Whilst this is quite possible, there's no simple way to take a copy of those records. Now there is.

Testing Photographs and Procedure

(This image has a bug in it but that has been fixed)
image

Changelog

🆑
add: Added a print button to the ASRS audit log.
/:cl:

@realforest2001 realforest2001 added this to the Project ARES milestone May 25, 2024
@github-actions github-actions bot added UI deletes nanoui/html Feature Feature coder badge labels May 25, 2024
@vero5123
Copy link
Contributor

This is mad copy pasta, I know because I copy pastad the same thing for one of my prs.

Copy link
Contributor

@vero5123 vero5123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks aside, maybe it would be best if there was a cooldown on the print option.

202403290234.3.mp4

@vero5123 vero5123 mentioned this pull request May 30, 2024
Copy link
Contributor

@vero5123 vero5123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks

code/game/machinery/ARES/ARES_interface.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface.dm Outdated Show resolved Hide resolved
@harryob harryob enabled auto-merge June 4, 2024 12:47
@harryob harryob added this pull request to the merge queue Jun 4, 2024
Merged via the queue into cmss13-devs:master with commit 39d51d8 Jun 4, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jun 4, 2024
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
# About the pull request

Allows the ASRS Audit Log to be printed from the ARES Interface.

# Explain why it's good for the game

Many times I've seen CMB request access to the audit log for the
purposes of checking on black market activity. Whilst this is quite
possible, there's no simple way to take a copy of those records. Now
there is.


# Testing Photographs and Procedure
(This image has a bug in it but that has been fixed)

![image](https://github.com/cmss13-devs/cmss13/assets/41653574/25ad5f12-7c8f-48c8-8798-b2039f5f7d0c)


# Changelog
:cl:
add: Added a print button to the ASRS audit log.
/:cl:

---------

Co-authored-by: Vero <[email protected]>
Co-authored-by: harryob <[email protected]>
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants