Allow Surgery, construction small puddles. #6340
Conversation
github-actions
bot
added
Mapping
|
I wonder if you could adjust it in another way by making the plasteel doors cost 10 plasteel instead of 8. That way it will divide evenly with either the 30 or the increase to 40 that you suggested. Purchasing more plasteel in the vendor by 10 will also make sure you will not have any left over plasteel. |
I want to improve the qol of com tech. |
10 plasteel per cade is insane . you would be better off making rwalls lmao |
code/game/machinery/vending/vendor_types/squad_prep/squad_engineer.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Zonespace <[email protected]>
hislittlecuzingames
changed the title
|
@Zonespace27 @Nanu308 |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Doesn't make really any sense that you'd be allowed to construct or do surgery on hot springs.
There was a problem hiding this comment.
They don't appear to be hot; do they cause damage? Otherwise, I'm not sure how one would make said distinction unless they read the lore.
If someone can walk in it without getting hurt, then it would make sense that someone could lay on a rollerbed where only the wheels are in the water.
Last night on Desert Dam, I was watching a medic explain that shallow puddles doesn't let people do surgery.
It's just small water puddles.
The consistency is when water is a maximum of one "full" water tile on the shortest distance across the body of water.
I was imagining that puddles were there for visual flare.
Some puddles are in really gameplay inconvenient spots like the area around an FOB, or a safe wall near major combat zones.
I'm not sure if I'm explaining myself coherently.
There was a problem hiding this comment.
Don't allow surgery on hot springs. Its not some niche lore thing. The entire icy environment is lush from the hot springs. The area is called hot springs. They are intended to be hot springs.
maps/map_files/Kutjevo/Kutjevo.dmm
Outdated
There was a problem hiding this comment.
Whats special about the left lake that it allows surgery but the others don't?
There was a problem hiding this comment.
The other ponds are more than 1 tile "deep".
I decided to just allow surgery on all the ponds to avoid confusion.
I assume it'll just be changed that way in a few months anyway.
…ingames/cmss13 into misc-polish-and-qol
hislittlecuzingames
changed the title
hislittlecuzingames
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
added
the
Merge Conflict
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
In files changed, I see some deleted sections. They may all exist in Kutjevo only. |
|
I have to redo the merge conflicts and use the hook. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Allows Surgery, construction in what look like small puddles
Explain why it's good for the game
Allows surgery and construction to be done in shallow water and shallow puddles. My rule was "There can only be one 'full' water tile in the shortest path across the depth of the puddle. if the shortest path is 2 or more 'full' water tiles, it's too deep to do surgery."
Select "long" puddles allow it if they're still only 1 tile at most for the shortest path.
My lore imagination says "okay, this is ankle-deep water, maybe shin-deep, but not knee-deep, so a roller bed should be mostly unobstructed, and the water isn't flowing. Beachheads have waves, but not puddles. Ponds are too deep."
Also, I added "deep" water sprites to some places so it would indicate "this is a puddle you cannot do surgery in" because it's "too deep."
Testing Photographs and Procedure
I allowed surgery in another PR.
Same code.
Changelog
🆑
qol: Surgery and construction allowed on select small puddles.
/:cl: