Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes it possible for all Officers and all NCO's (E4+) to recommend people for medals. #6343

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

TheGamerdk
Copy link
Contributor

@TheGamerdk TheGamerdk commented May 27, 2024

About the pull request

I've been meaning to do this.

Corporal and above + all officers can recommend medals.

Explain why it's good for the game

Testing Photographs and Procedure

I tested it.

Tried to give a medal recommendation as a PFC: Failed
Tried to give a medal recommendation as a FTL: Success
Tried to give a medal recommendation as an SO: Success
Tried to give a medal recommendation as XO: Success

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: All officers and NCO's can now recommend people for medals.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label May 27, 2024
@Drulikar Drulikar marked this pull request as draft May 28, 2024 00:02
@TheGamerdk
Copy link
Contributor Author

TheGamerdk commented May 28, 2024

todo
Retrieve the paygrade
Check that it’s /datum/paygrade/marine
Check that ranking >= 3 (E1 = 0)

@TheGamerdk TheGamerdk closed this May 28, 2024
@TheGamerdk TheGamerdk changed the title Makes it possible for ALL Officers AND ALL NCO's (E4+) to recommend people for medals. Makes it possible for all Officers and all NCO's (E4+) to recommend people for medals. May 28, 2024
@TheGamerdk TheGamerdk reopened this May 28, 2024
@TheGamerdk TheGamerdk marked this pull request as ready for review May 28, 2024 18:50
@TheGamerdk TheGamerdk requested a review from Drulikar May 28, 2024 18:50
@ProfanityTM
Copy link

Does this apply to ASO? They couldn't do medal recomendations last I recall.

@TheGamerdk
Copy link
Contributor Author

Does this apply to ASO? They couldn't do medal recomendations last I recall.

They’re an officer, so yes :)

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of note, this allows a CO to make medal recommendations, but I guess this would allow you to prepare a medal?

code/datums/medal_awards.dm Show resolved Hide resolved
@Drulikar Drulikar added this pull request to the merge queue Jun 4, 2024
Merged via the queue into cmss13-devs:master with commit 403760a Jun 4, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jun 4, 2024
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
…eople for medals. (cmss13-devs#6343)

# About the pull request

I've been meaning to do this.

Corporal and above + all officers can recommend medals.


# Explain why it's good for the game
# Testing Photographs and Procedure
I tested it.

Tried to give a medal recommendation as a PFC: Failed
Tried to give a medal recommendation as a FTL: Success
Tried to give a medal recommendation as an SO: Success
Tried to give a medal recommendation as XO: Success

<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
add: All officers and NCO's can now recommend people for medals.
/:cl:
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants