Reduce chem smoke logging spam #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
May 29, 2024
cm13-github
added a commit
that referenced
this pull request
May 29, 2024
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
# About the pull request Smoke reactions are now a niche admin log, and somewhat spam reduced by storing the last event in a static var. The reason why I say somewhat is because say two different people spray at the same time the last event will swap between both people each cloud. Now the hour/minute, area, chem, and user are used to create a siganture. # Explain why it's good for the game Chem smoke is now commonly used in rounds so its better to keep information sent to admins more relevant rather than spammed. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Second log was after a minute elapsed (which makes the signature unique again)  </details> # Changelog :cl: Drathek admin: Logging for chem smoke is now niche logged and less spammy /:cl:
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Smoke reactions are now a niche admin log, and somewhat spam reduced by storing the last event in a static var. The reason why I say somewhat is because say two different people spray at the same time the last event will swap between both people each cloud. Now the hour/minute, area, chem, and user are used to create a siganture.
Explain why it's good for the game
Chem smoke is now commonly used in rounds so its better to keep information sent to admins more relevant rather than spammed.
Testing Photographs and Procedure
Screenshots & Videos
Second log was after a minute elapsed (which makes the signature unique again)
Changelog
🆑 Drathek
admin: Logging for chem smoke is now niche logged and less spammy
/:cl: