Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost orbit refactor #6346

Merged
merged 4 commits into from
May 29, 2024
Merged

Ghost orbit refactor #6346

merged 4 commits into from
May 29, 2024

Conversation

mullenpaul
Copy link
Contributor

@mullenpaul mullenpaul commented May 28, 2024

About the pull request

Some usability changes to the orbit menu and general refactoring.

  • Marines now appear per squad
  • Marine job icons now appear in line with the name
  • Marine job is sorted by job, similar to squad UI
  • Xenos now appear per hive

Explain why it's good for the game

Improving usability is a good thing

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

https://media.discordapp.net/attachments/964684928161808384/1244701305751212084/image.png?ex=6656baac&is=6655692c&hm=6d0bb3234ac1d511e55978a046414f080c95f8c5dd2bedc51bfb3787ee1ff754&=&format=webp&quality=lossless&width=958&height=1342

https://media.discordapp.net/attachments/964684928161808384/1244783033517871154/image.png?ex=665706ca&is=6655b54a&hm=591f86a278ab6217d28a6890efef7a344f4467b25432a8c1bcab3723004e223b&=&format=webp&quality=lossless&width=958&height=1342

Changelog

🆑
ui: orbit menu now splits marine squads
ui: orbit menu now splits xeno hives
ui: orbit menu sorts marines by job
/:cl:

@github-actions github-actions bot added the UI deletes nanoui/html label May 28, 2024
@harryob harryob added this pull request to the merge queue May 29, 2024
Merged via the queue into cmss13-devs:master with commit 63f8286 May 29, 2024
28 checks passed
cm13-github added a commit that referenced this pull request May 29, 2024
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

Some usability changes to the orbit menu and general refactoring.

- Marines now appear per squad
- Marine job icons now appear in line with the name
- Marine job is sorted by job, similar to squad UI
- Xenos now appear per hive

# Explain why it's good for the game
Improving usability is a good thing

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.


https://media.discordapp.net/attachments/964684928161808384/1244701305751212084/image.png?ex=6656baac&is=6655692c&hm=6d0bb3234ac1d511e55978a046414f080c95f8c5dd2bedc51bfb3787ee1ff754&=&format=webp&quality=lossless&width=958&height=1342


https://media.discordapp.net/attachments/964684928161808384/1244783033517871154/image.png?ex=665706ca&is=6655b54a&hm=591f86a278ab6217d28a6890efef7a344f4467b25432a8c1bcab3723004e223b&=&format=webp&quality=lossless&width=958&height=1342

</details>


# Changelog
:cl:
ui: orbit menu now splits marine squads
ui: orbit menu now splits xeno hives
ui: orbit menu sorts marines by job
/:cl:
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants