Unsorted cleanup #6352
Merged
Unsorted cleanup #6352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Changelog
|
you should do a funny and fix all the single letter vars in the codebase. |
|
I choose life. |
harryob
approved these changes
Jun 4, 2024
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
# About the pull request Cleans up some duplicate, unused, and/or obsolete (due to native DM implementation) code in `unsorted.dm`. Removed (unused): - `is_hot` - `sign` - `rename_self` - `get_sorted_mobs` (`sortmobs` is the one you're thinking of) - `getxenos` - `getpreds` - `gethumans` - `getsurvivors` - `getertmembers` - `get_holograms` - `sortxenos` - `sortpreds` - `sorthumans` - `sortsurvivors` - `sortertmembers` - `blockhollow` - `get_random_zero_sum_variances` - `IsValidSrc` - `convert_to_json_text` Replaced (functionally identical): - `InRange` to `ISINRANGE` - `between`, `dd_range` to `clamp` (only difference was argument order) - `check_bitflag` to `HAS_FLAG` Replaced (special): - `getsynths`, `sortsynths` were only used once for MOOC, which only really needed `GLOB.human_mob_list` filtered by `issynth()` <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Less duplication leads to greater maintainability. # Testing Photographs and Procedure Boots without issue. # Changelog No player-facing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Cleans up some duplicate, unused, and/or obsolete (due to native DM implementation) code in
unsorted.dm.Removed (unused):
is_hotsignrename_selfget_sorted_mobs(sortmobsis the one you're thinking of)getxenosgetpredsgethumansgetsurvivorsgetertmembersget_hologramssortxenossortpredssorthumanssortsurvivorssortertmembersblockhollowget_random_zero_sum_variancesIsValidSrcconvert_to_json_textReplaced (functionally identical):
InRangetoISINRANGEbetween,dd_rangetoclamp(only difference was argument order)check_bitflagtoHAS_FLAGReplaced (special):
getsynths,sortsynthswere only used once for MOOC, which only really neededGLOB.human_mob_listfiltered byissynth()Explain why it's good for the game
Less duplication leads to greater maintainability.
Testing Photographs and Procedure
Boots without issue.
Changelog
No player-facing changes.