Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poncho Vendable!!! #6353

Closed
wants to merge 4 commits into from
Closed

Conversation

567Turtle
Copy link
Contributor

@567Turtle 567Turtle commented Jun 1, 2024

About the pull request

adds ponchos (drippy) to the squad prep vendor

Explain why it's good for the game

Ponchos are drippy and do not effect anything but the style of marines.

Screenshots & Videos

works probably

Changelog

🆑
add: Ponchos can be vended from the uniform supply vendor (It's also now properly layered and transparent)
/:cl:

la
@github-actions github-actions bot added the Feature Feature coder badge label Jun 1, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, Sammy would like the layering issues fixed for ponchos & belts fixed before they are obtainable by marines. Speak with them for more details.

@Drulikar Drulikar marked this pull request as draft June 1, 2024 02:30
@567Turtle 567Turtle marked this pull request as ready for review June 1, 2024 18:42
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jun 6, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jun 6, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 14, 2024
@github-actions github-actions bot closed this Jun 22, 2024
@harryob
Copy link
Member

harryob commented Sep 20, 2024

without commenting on if this pr should exist or be merged

@harryob harryob reopened this Sep 20, 2024
@cmss13-ci cmss13-ci bot removed the Stale beg a maintainer to review your PR label Oct 27, 2024
@Blundir
Copy link
Contributor

Blundir commented Oct 28, 2024

Hello, i am against them being present in regular rounds, unless you find out a way to add things in vendors on specific maps only, i'm not gonna approve this

@Blundir Blundir closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants