Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctors spawn with dark blue scrubs, surgeons spawn with green scrubs #6354

Merged
merged 2 commits into from Jun 4, 2024
Merged

doctors spawn with dark blue scrubs, surgeons spawn with green scrubs #6354

merged 2 commits into from Jun 4, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2024

About the pull request

doctors spawn with dark blue scrubs, surgeons spawn with green scrubs

Explain why it's good for the game

highly flavorful (soulful, even) and true to old scrub color hierarchies where surgical scrubs are the green ones and medical scrubs are /whatever/ color (dark blue usually for physicians, though). not impeding in a meaningful way, i'd wager, since people can still freely vend their preferred scrubs, just neat.

feels like this makes sense and fits since our nurses adhere to the Scrub Hierarchy with their respective light blue scrubs on spawn

Testing Photographs and Procedure

image

one of them did residency for 3 years and one of them did residency for five years !! you will now know!!! unless they go to their vendor, then all bets are off !!

tested; without duplicating Every Thing from the parent doc datum for the surgeon clothing datum, they spawn shoeless and bagless, and this makes me sad. if there's a better way to NOT copy 5 extra lines, i'm all ears

Changelog

🆑
add: Doctors will spawn in dark blue scrubs by default; Setting your preferred job title to "Surgeon" for doctor roles will now spawn you in green scrubs
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jun 1, 2024
@harryob harryob added this pull request to the merge queue Jun 4, 2024
Merged via the queue into cmss13-devs:master with commit a6fc1c2 Jun 4, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jun 4, 2024
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
…cmss13-devs#6354)

# About the pull request

doctors spawn with dark blue scrubs, surgeons spawn with green scrubs

# Explain why it's good for the game
highly flavorful (soulful, even) and true to old scrub color hierarchies
where surgical scrubs are the green ones and medical scrubs are
/whatever/ color (dark blue usually for physicians, though). not
impeding in a meaningful way, i'd wager, since people can still freely
vend their preferred scrubs, just neat.

feels like this makes sense and fits since our nurses adhere to the
Scrub Hierarchy with their respective light blue scrubs on spawn

# Testing Photographs and Procedure

![image](https://github.com/cmss13-devs/cmss13/assets/29965103/4b614d87-93c9-4a05-af6f-e465a3db20d3)

one of them did residency for 3 years and one of them did residency for
five years !! you will now know!!! unless they go to their vendor, then
all bets are off !!

tested; without duplicating Every Thing from the parent doc datum for
the surgeon clothing datum, they spawn shoeless and bagless, and this
makes me sad. if there's a better way to NOT copy 5 extra lines, i'm all
ears

# Changelog

:cl:
add: Doctors will spawn in dark blue scrubs by default; Setting your
preferred job title to "Surgeon" for doctor roles will now spawn you in
green scrubs
/:cl:

---------

Co-authored-by: nefarious <[email protected]>
Co-authored-by: Vero <[email protected]>
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants