Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the firing sound of the M44 combat revolver #6356

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

VileBeggar
Copy link
Contributor

@VileBeggar VileBeggar commented Jun 1, 2024

About the pull request

changes the firing sound of the M44 revolver to a beefier one

Explain why it's good for the game

after the damage buff the revolver has received, the gun feels notably more punchier but i feel as if the firing sound has stayed behind in that regard. it sounds like a peashooter. i think that with this change it's an objectively better sounding weapon.

Testing Photographs and Procedure

Screenshots & Videos

old vs new comparison

rebolba.mp4

Changelog

🆑
soundadd: The M44 combat revolver has had its firing sound changed.
/:cl:

@github-actions github-actions bot added the Sound Blast 5 minutes of bass boosted music to our players label Jun 1, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 9, 2024
@KoishiVibe
Copy link

If this doesn't go through, would you mind me porting it to PVE13?

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jun 10, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 17, 2024
@Drulikar Drulikar added this pull request to the merge queue Jun 19, 2024
Merged via the queue into cmss13-devs:master with commit 6dd490a Jun 19, 2024
29 checks passed
cm13-github added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sound Blast 5 minutes of bass boosted music to our players Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants