Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USCM ERT Station | USS Kurtz #6368

Merged
merged 13 commits into from
Jul 8, 2024
Merged

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Jun 3, 2024

About the pull request

Adds a USCM ERT station that can be used for ERTs. The station consists of the entire lower-deck and a tiny snap-shot of the upper deck based off of the Sulaco.

The name of the ship is the 'USS Kurtz', this is based off of the character from Joseph Conrad's novel 'Heart of Darkness', this is meant to follow the criteria of USCM ships being named off of concepts, people or places from his novels.

Currently only the CBRN ERT will use this.

Explain why it's good for the game

Bit odd the CBRN were coming from a WY ship. More roleplay options as to being rescued by a USCM warship, or for admin events

Nice Nostalgia to see the ole Sulaco back in action as well.

Testing Photographs and Procedure

Screenshots & Videos

Changelog

🆑
mapadd: The USS Kurtz has been added as a USCM affiliated ERT station. The design off the USS Kurtz is based off of the USS Sulaco, from older versions of CM-SS13. The USS Kurtz features the entire lower-deck and a snapshot of the upper deck.
mapadd: The USCM CBRN ERT will use the USS Kurtz as their homebase.
/:cl:

@Steelpoint Steelpoint requested a review from Nanu308 as a code owner June 3, 2024 05:43
@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jun 3, 2024
Steelpoint added 2 commits June 3, 2024 15:32
@Steelpoint Steelpoint changed the title USCM ERT Station USCM ERT Station | Sulaco Lower Deck Jun 3, 2024
@DexterDude
Copy link
Contributor

Narcissus is the name of the escape pod in Alien.

@Steelpoint
Copy link
Contributor Author

Narcissus is the name of the escape pod in Alien.

Damn. I'll pick another name out of the Conrad hat.

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like a lot of this - but you'll want the USCM semiotics (https://docs.google.com/document/d/1fONsGxSfF_ZvSZZygxMxAAofvLY_FdEBRgrhXgEQPfI/edit) on the walls, and consider popping pipes/disposals under the catwalks - even just for flavour, they suggest a larger vessel

@harryob harryob marked this pull request as draft June 4, 2024 11:34
@Steelpoint
Copy link
Contributor Author

I've expanded the lower deck to cover most of the original layout, and I've added piping, vents and semiotics. If more semiotics are needed just let me know.

@Steelpoint Steelpoint marked this pull request as ready for review June 4, 2024 14:02
@Steelpoint Steelpoint marked this pull request as draft June 4, 2024 16:08
@github-actions github-actions bot added the Sprites Remove the soul from the game. label Jun 4, 2024
@Steelpoint
Copy link
Contributor Author

Ok, did some more aesthetic work, few more semiotics, I've added two fake upper-deck areas so that the ladders actually work and I've added a 'USS KURTZ' spraypaint near a window.

@Steelpoint Steelpoint marked this pull request as ready for review June 4, 2024 16:52
@Steelpoint Steelpoint changed the title USCM ERT Station | Sulaco Lower Deck USCM ERT Station | USS Kurtz Jun 5, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 13, 2024
@Steelpoint
Copy link
Contributor Author

stale comment

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jun 16, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 24, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jun 27, 2024
@Drulikar
Copy link
Contributor

Stale exempt until map/sprite review.

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking nice with the added polishing

CleanShot 2024-07-08 at 07 40 11@2x
this font doesn't match the almayer's - is that intentional? the almayer uses Stencil Std Regular

@harryob harryob marked this pull request as draft July 8, 2024 06:51
@harryob harryob removed the Stale Exempt PR can't go stale label Jul 8, 2024
@Steelpoint
Copy link
Contributor Author

this font doesn't match the almayer's - is that intentional? the almayer uses Stencil Std Regular

I was unaware as to what the font was, I'll remedy that issue shortly.

@Steelpoint Steelpoint marked this pull request as ready for review July 8, 2024 07:20
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it!

@harryob harryob added the Mapping Approved adds 500 new dict keys label Jul 8, 2024
@harryob harryob added this pull request to the merge queue Jul 8, 2024
Merged via the queue into cmss13-devs:master with commit 83239d4 Jul 8, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 8, 2024
@Steelpoint Steelpoint deleted the USCMStation branch July 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants