Weyland-Yutani ID Console #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Fix
harryob
approved these changes
Jun 4, 2024
| @@ -332,18 +352,26 @@ | |||
| data["jobs"][department] = department_jobs | |||
|
|
|||
| var/list/regions = list() | |||
| for(var/i in 1 to 7) | |||
| for(var/i in 1 to is_weyland ? 6 : 7) | |||
There was a problem hiding this comment.
i do not enjoy how this is coded, but it's not really on you
cm13-github
added a commit
that referenced
this pull request
Jun 4, 2024
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> # About the pull request Repairs the ID mod console "centcom" variable (renames it to weyland). Allows this new WY version of the console to correctly assign Corporate ID Accesses and job presets. Renames a couple PMC jobs (no impact due to no playtime tracking) Adds a whole bunch of WY jobs, including the PMCs, so they'll now track playtime. # Explain why it's good for the game Makes it a bit easier to dynamically update IDs in WY related events. I know I've encountered plenty of times where I've wanted to add corporate accesses to certain people but had to resort to variable editing. # Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- !! If you are modifying sprites, you **must** include one or more in-game screenshots or videos of the new sprites. !! -->   # Changelog :cl: fix: Changing an Identification Computer to is_weyland (formerly is_centcom) now works correctly and allows assignment of corporate accesses or presets. code: Added two procs for interpreting WY access information in the UI. code: Added separate role groups for PMC and Corporate job defines. add: Added ACCESS_WY_DATABASE as a requirement to use the WY subtype console. add: Added a WY subtype for crew monitor. code: Renamed the faction defines explicitly relating to static defences due to confusion over FACTION_WY and FACTION_WEYLAND. /:cl: <!-- Both :cl:'s are required for the changelog to work! -->
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Repairs the ID mod console "centcom" variable (renames it to weyland).
Allows this new WY version of the console to correctly assign Corporate ID Accesses and job presets.
Renames a couple PMC jobs (no impact due to no playtime tracking)
Adds a whole bunch of WY jobs, including the PMCs, so they'll now track playtime.
Explain why it's good for the game
Makes it a bit easier to dynamically update IDs in WY related events. I know I've encountered plenty of times where I've wanted to add corporate accesses to certain people but had to resort to variable editing.
Testing Photographs and Procedure
Changelog
🆑
fix: Changing an Identification Computer to is_weyland (formerly is_centcom) now works correctly and allows assignment of corporate accesses or presets.
code: Added two procs for interpreting WY access information in the UI.
code: Added separate role groups for PMC and Corporate job defines.
add: Added ACCESS_WY_DATABASE as a requirement to use the WY subtype console.
add: Added a WY subtype for crew monitor.
code: Renamed the faction defines explicitly relating to static defences due to confusion over FACTION_WY and FACTION_WEYLAND.
/:cl: