Buff XM88

[Steelpoint]

About the pull request

This PR changes the XM88 to have comparable values as if the weapon had a barrel charger attached to it, this includes a buff of its damage to 104, and a decrease to its inherent accuracy and rate of fire.

Explain why it's good for the game

The removal of the barrel charger from the gameplay loop had the unintended side-affect of indirectly nerfing the XM88 in a significant manner. Prior to its removal the barrel charger was a "must-have" attachment for the weapon, as it brought its damage up to a level of greater lethality, wherein without it the weapon now struggles more so against hardened targets. Furthermore, the weapons higher skill requirement means that you will regularly miss shots on a target, thus the weapon having a higher damage upfront rewards you for landing your shots.

To account for this, this PR effects the change to presume the weapon is under the benefits and drawbacks of having a barrel charger attached to it. Meaning the gun has a higher damage per bullet but suffers a rate of fire decrease and a major decrease in its accuracy.

Functionally this is bringing the weapon back to its older state that was what the majority of the player base grew to expect the weapon to perform.

Due to the major nerfs to the extended barrel, the now ability to attach it to this weapon comports a almost non-existant boon to the weapon and thus is not a point of balance contention.

Furthermore, after doing some offline testing I can ascertain that the average time-to-kill on a stationary target in white-room conditions is almost virtually unchanged. For example, a Warrior can expect to be dead in 8 seconds from both the original and this new version. The difference really comes down to the weapon having slightly higher damage up-front if you do land your shot.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: The XM88 now deals higher damage per-bullet at the cost of a slightly lower rate of fire and accuracy. This is identical to as if it had a barrel charger attached to it.
balance: Per the above, the barrel charger is no longer compatible with the XM88.
/:cl:

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[Steelpoint]

Stale comment

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[Drulikar]

Please also make it incompatible with the barrel charger then. They are generally removed from the loop except when found in maps.

[Steelpoint]

Done. (Maybe we should just remove the BC but that's another PR/topic)