Fix range usages #6378
Merged
Fix range usages #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
the
Needs Testing
Drulikar
added
the
Testmerge Candidate
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 7, 2024
3 tasks
harryob
approved these changes
Jun 7, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 7, 2024
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
# About the pull request So it turns out some usages of range are wrong https://www.byond.com/docs/ref/#/proc/range with the arguments in the wrong order. This might have some unintended consequences as some code that never worked now works... # Explain why it's good for the game Fixes issues such as  # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: Fixed some usages of the proc range such as for delimbing /:cl:
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
So it turns out some usages of range are wrong https://www.byond.com/docs/ref/#/proc/range with the arguments in the wrong order. This might have some unintended consequences as some code that never worked now works...
Explain why it's good for the game
Fixes issues such as
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Fixed some usages of the proc range such as for delimbing
/:cl: