Fix Round Time Offset #6384
Merged
Fix Round Time Offset #6384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
the
Testmerge Candidate
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 7, 2024
3 tasks
harryob
approved these changes
Jun 7, 2024
cm13-github
added a commit
that referenced
this pull request
Jun 7, 2024
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
# About the pull request As of byond 515.1637 time2text's behavior has changed again (see https://www.byond.com/forum/post/2922387 ). This fixes the timezone offset used for round time by ensuring time2text is parsing a positive number since it now treats 0 like it does negative numbers somreason. # Explain why it's good for the game Fixes cmss13-devs#6381 # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>  </details> # Changelog :cl: Drathek fix: Fixed round time having the wrong timezone offset because of an engine change to time2text /:cl:
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
As of byond 515.1637 time2text's behavior has changed again (see https://www.byond.com/forum/post/2922387 ). This fixes the timezone offset used for round time by ensuring time2text is parsing a positive number since it now treats 0 like it does negative numbers somreason.
Explain why it's good for the game
Fixes #6381
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
fix: Fixed round time having the wrong timezone offset because of an engine change to time2text
/:cl: