Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes nazi jacket sprite from suits.dmi #6389

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2024

About the pull request

removes nazi jacket sprite from suits.dmi

Explain why it's good for the game

  1. most modern SS13 codebases have specific stipulations in contributing not to include nazi iconography or themes; need i point out we probably best not keep it in the repo either
  2. unused anywhere

Testing Photographs and Procedure

image

Changelog

🆑
del: removes the nazi jacket sprite from suits.dmi
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Removal snap labels Jun 6, 2024
@Blundir
Copy link
Contributor

Blundir commented Jun 7, 2024

Maybe you'd, you know, remove many other unused sprites in there as well? Which is like half of them, that file probably never seen cleaning

@ghost
Copy link
Author

ghost commented Jun 7, 2024

Maybe you'd, you know, remove many other unused sprites in there as well? Which is like half of them, that file probably never seen cleaning

yea maybe, i just saw this one as glaringly worth removal and pressing "delete" when i know it's in there from prior looking is really easy since i just got home from work and don't want to validate and check every other file in there

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDB is either dead or explicitly filters out that name refusing to run it. But checked out the branch regardless and I only see 1 sprite removed.

@realforest2001
Copy link
Member

IconDB is down for the moment it appears. But I see no other alterations either.

@realforest2001 realforest2001 added the Sprites Approved confirmed no stray pixels label Jun 7, 2024
@harryob harryob added this pull request to the merge queue Jun 7, 2024
Merged via the queue into cmss13-devs:master with commit f4f08bd Jun 7, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jun 7, 2024
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
# About the pull request
removes nazi jacket sprite from suits.dmi

# Explain why it's good for the game
1. most modern SS13 codebases have specific stipulations in contributing
not to include nazi iconography or themes; need i point out we probably
best not keep it in the repo either
2. unused anywhere

# Testing Photographs and Procedure

![image](https://github.com/cmss13-devs/cmss13/assets/29965103/829d03b7-e655-4976-90d2-1da66942905e)

# Changelog
:cl:
del: removes the nazi jacket sprite from suits.dmi
/:cl:

Co-authored-by: nefarious <[email protected]>
Co-authored-by: Drathek <[email protected]>
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal snap Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants