Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes observe menu bug #6391

Merged
merged 4 commits into from
Jun 20, 2024
Merged

fixes observe menu bug #6391

merged 4 commits into from
Jun 20, 2024

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Jun 7, 2024

About the pull request

Fixes observe menu bug, PMC engineer was being listed as Human category and not Survivor round 22539. Looking at the code it seems like the same thing should happen for PMC medic too, so made the same changes there.

Explain why it's good for the game

My immersion.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: more survivors now listed in survivor category on observe menu
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 7, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 15, 2024
Copy link
Member

@realforest2001 realforest2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to change their assignments, only remove the 'rank' var override from the presets.

@realforest2001 realforest2001 removed the Stale beg a maintainer to review your PR label Jun 17, 2024
@zzzmike
Copy link
Contributor Author

zzzmike commented Jun 17, 2024

You don't need to change their assignments, only remove the 'rank' var override from the presets.

ah okay thanks, and thanks for giving the preset in the round as well

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure there's still more offenders like this, but tackle them as you find them.

@Drulikar Drulikar added this pull request to the merge queue Jun 20, 2024
Merged via the queue into cmss13-devs:master with commit 24632ad Jun 20, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants