-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to box vending in Requisitions #6397
Conversation
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
268cf27
to
91f4fbf
Compare
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
7038400
to
e024fce
Compare
stale exempt until reviewed |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
e024fce
to
d6bbb5b
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
About the pull request
Fixes Issue #6096
Some small improvements around the code that handles Requisitions' ammo box vendor filling logic. It now handles boxes that use handfuls (shotgun boxes) and also checks the vendor's inventory for if the boxes already exist to let the devs order them neatly as needed.
Also neatly added the various boxes to Requisitions' vendors that were auto-populated before.
Explain why it's good for the game
It makes the vendors nicer to use and keeps the ammo boxes consistent.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 ThePiachu
qol: Shotgun ammo boxes now behave like other ammo boxes in the Requisitions' vendors.
code: Ammo box maping code now handles pre-populated boxes in vendors, letting devs order them more neatly than before.
/:cl: