Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Anti-parasitic slightly more powerful to match larva gestation increases #6407

Conversation

wshuwshuwshi
Copy link
Contributor

@wshuwshuwshi wshuwshuwshi commented Jun 8, 2024

About the pull request

Larva gestation was sped up at one point or another, and that made Anti-parasitic too slow to actually prevent gestation or remove parasites at all
Applies a 1.5 multiplier to the potency removed from the larva timer.

Explain why it's good for the game

Larva gestation was sped up at one point or another, and that made Anti-parasitic too slow to actually prevent gestation or remove parasites at all. In its current state, Anti-Parasitic is incapable of removing larvae at higher levels, due to it being too slow acting, with a slight increase, it may be viable (of note, I'm not sure if the 1.5 multiplier is actually high enough to be able to counter-act and remove larvae, and may need to be increased further)
Of note, it still does potency burn damage, meaning that if it is at potency 8, it will do 8 burn damage to whatever the chemical is being metabolized in.

Gives the Antiparasitic chemical property its niche back. At lower levels it's supposed to delay the inevitable and buy time for the marine to get to surgeons, and at higher levels it's supposed to cure larvae from the marine. Currently, it's not powerful enough to do either to a noticeable degree.

Testing Photographs and Procedure

N/A. All that was done was add a 1.5 multiplier to the potency, when it is removed from the larva timer

Changelog

🆑
fix: Adds a 1.5x modifier to the amount taken from larva timer based on chem property level
fix: swaps the 1.5 multiplier for a delta_time multiplier
fix: improved the formatting of the code to have proper spacing
/:cl:

@kiVts
Copy link
Contributor

kiVts commented Jun 8, 2024

You need to have a changelog for this, check other PRs.

@github-actions github-actions bot added the Feature Feature coder badge label Jun 9, 2024
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 9, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 17, 2024
@Drulikar Drulikar added this pull request to the merge queue Jun 19, 2024
Merged via the queue into cmss13-devs:master with commit 07f5cbd Jun 19, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jun 19, 2024
@wshuwshuwshi wshuwshuwshi deleted the Improving-Anti-parasitic-to-be-up-to-par-with-gestation-increases branch June 19, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants