Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds upgraded fuel tanks to the research biomass machine #6415

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Jun 9, 2024

About the pull request

adds new upgraded smoke and normal fuel tanks printable by the biomass machine
upgraded smoke tank has a 200 unit capacity instead of 100
upgraded custom tank has 60 max intensity and 50 duration, 7 tile range and 200 unit capacity (you still have to make a flamer fuel that reaches these caps)
i will be severely impressed if anyone manages to make a chem that even goes above 50 intensity

Explain why it's good for the game

lets research reach the full potential of custom flamer chems while still putting it behind a reasonable paywall

Testing Photographs and Procedure

it works

Changelog

🆑
add: Added new upgraded incinerator fuel tanks printable by the biomass analyzer.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Jun 9, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 18, 2024
code/modules/projectiles/magazines/flamer.dm Outdated Show resolved Hide resolved
code/modules/projectiles/magazines/flamer.dm Outdated Show resolved Hide resolved
code/modules/projectiles/magazines/flamer.dm Outdated Show resolved Hide resolved
code/datums/research_upgrade_datum.dm Outdated Show resolved Hide resolved
code/datums/research_upgrade_datum.dm Outdated Show resolved Hide resolved
code/datums/research_upgrade_datum.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jun 19, 2024
@Drulikar Drulikar marked this pull request as draft June 19, 2024 01:17
@iloveloopers iloveloopers marked this pull request as ready for review June 19, 2024 01:46
@Drulikar Drulikar marked this pull request as draft June 19, 2024 01:56
@iloveloopers
Copy link
Contributor Author

null define added

@iloveloopers iloveloopers marked this pull request as ready for review June 19, 2024 02:33
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jun 19, 2024
@Drulikar Drulikar enabled auto-merge June 19, 2024 03:15
@Drulikar Drulikar added this pull request to the merge queue Jun 19, 2024
Merged via the queue into cmss13-devs:master with commit 29c06e4 Jun 19, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jun 19, 2024
@iloveloopers iloveloopers deleted the upgradetank branch June 23, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants