Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique sound and magazine sprite for XM43E1 #6417

Conversation

Releasethesea
Copy link
Contributor

@Releasethesea Releasethesea commented Jun 10, 2024

About the pull request

adds a unique sound and magaqine sprite to the XM43, this allows the rifle to be more easily distinguished

Explain why it's good for the game

being able to tell the difference between the AMR and normal sniper without hearing it is annoying, now you can tell at a glance due to having different magazine sprites, as for the sound, i think its good to have a difference between the PMC M42C and XM43E1

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

https://imgur.com/a/r8hGerO (sprites)

https://files.catbox.moe/8zb5nx.ogg (sound)

Changelog

🆑
add: Adds unique sound and magazine sprite to the XM43E1
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Sound Blast 5 minutes of bass boosted music to our players Feature Feature coder badge labels Jun 10, 2024
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Not enough visual difference between the standard sniper mag and the XM43 - from a distance they are exactly identical.

image

Try copying the color palette from the XM itself and then notice the length of the magazine and of the caliber (10x99) - make the magazine wider as a result and maybe adjust the color to brown and blue.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 22, 2024
@Drulikar Drulikar marked this pull request as draft June 27, 2024 03:16
@github-actions github-actions bot closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sound Blast 5 minutes of bass boosted music to our players Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants