Adds a warning to potentially-laggy uses of drop-bomb
#6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Bombs with linear falloff, power >= 500, and falloff <= 5% of power have an extra confirmation before dropping.
Explain why it's good for the game
While there is an existing bomb cap (5000), this confirmation just makes sure admins know what they're doing before dropping the bomb.
no this has nothing to do with me bringing the server to a haltChangelog
🆑
admin: Potentially laggy uses of the drop-bomb verb now have a confirmation warning.
/:cl: