Abomination Tutorial #6442
Abomination Tutorial #6442
Conversation
|
Can there be an exception for people that already have big playtime or smth? |
It's a two minute tutorial. At the moment, I'm not interested in adding an exception for this. |
code/modules/mob/living/carbon/xenomorph/strains/castes/drone/healer.dm
Outdated
Show resolved
Hide resolved
| return ..() | ||
| return ..() |
There was a problem hiding this comment.
In almost every other case, you have ensured the parent is called prior to checks that may prevent the ability from going off. Should this one be different?
| @@ -149,6 +149,7 @@ | |||
| predatoralien.recalculate_armor() | |||
| playsound(predatoralien, 'sound/voice/predalien_growl.ogg', 75, 0, status = 0) | |||
| apply_cooldown() | |||
| return ..() | |||
There was a problem hiding this comment.
In almost every other case, you have ensured the parent is called prior to checks that may prevent the ability from going off. Should this one be different?
| @@ -276,8 +276,10 @@ | |||
| addtimer(CALLBACK(xeno.hive, TYPE_PROC_REF(/datum/hive_status, free_respawn), xeno.client), 5 SECONDS) | |||
|
|
|||
| xeno.gib(create_cause_data("sacrificing itself", src)) | |||
| return ..() | |||
There was a problem hiding this comment.
In almost every other case, you have ensured the parent is called prior to checks that may prevent the ability from going off. Should this one be different?
There was a problem hiding this comment.
you have ensured the parent is called prior to checks that may prevent the ability from going off
In the case of use_ability(), that doesn't seem to be the case?
…healer.dm Co-authored-by: Drathek <[email protected]>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Drulikar
added
Stale Exempt
# About the pull request Calling the parent of all actions (#6442) caused a lot of bugs, this fixes that. Closes #6755 Closes #6753 Closes #6732 Closes #6742 # Explain why it's good for the game Bugs are bad # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Tested on practically every object that has a use-in-hand functionality with an action button. </details> # Changelog :cl: fix: Fixed a large amount of objects activating erroneous functionality (like an armor light) when using action buttons tied to that object. /:cl: Co-authored-by: John Doe <[email protected]>
About the pull request
"This'll be a nice and simple 2 hour PR" - Me, 6 hours ago
Adds a tutorial for how to play abom. You cannot roll abom without having completed its tutorial.
Explain why it's good for the game
More tutorials are good, and encouraging players to know the basics of a decently complicated and rare xeno before playing it is a good idea.
Changelog
🆑
add: Added a tutorial for xenomorph Abominations. You must complete the tutorial before being able to roll for Abomination.
/:cl: