Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cas targeting incorrect signals #6459

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Fixes cas targeting incorrect signals #6459

merged 3 commits into from
Jun 16, 2024

Conversation

vero5123
Copy link
Contributor

@vero5123 vero5123 commented Jun 13, 2024

About the pull request

Closes #6447, untested.

Explain why it's good for the game

bug bad

Changelog

🆑
fix: fixes cas being able to target shipside signals
/:cl:

@vero5123 vero5123 requested a review from fira as a code owner June 13, 2024 10:44
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 13, 2024
@vero5123 vero5123 marked this pull request as draft June 13, 2024 11:21
@vero5123 vero5123 marked this pull request as ready for review June 13, 2024 11:27
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, is there a particular reason this isn't in the valid_signal() check?

@harryob harryob marked this pull request as draft June 16, 2024 10:09
@vero5123
Copy link
Contributor Author

vero5123 commented Jun 16, 2024

actually, is there a particular reason this isn't in the valid_signal() check?

the valid_signal does a few checks like preventing the signal from being triggered from pockets. It's called multiple times during the process of executing the firemission, I just thought it wasn't really necessary to make sure it was ground z level for each check each time and we could just simply do the initial ground level check whenever when we try and get the target list for the dropship since all the subsequent checks come after that, maybe a few rare edge cases that wouldn't be covered but I can change it if necessary. Also, i'm probably going to refactor this altogether once I add the cas sim back so it will be changed regardless soon.

@harryob harryob marked this pull request as ready for review June 16, 2024 14:24
@harryob harryob added this pull request to the merge queue Jun 16, 2024
Merged via the queue into cmss13-devs:master with commit f09b3c2 Jun 16, 2024
30 checks passed
cm13-github added a commit that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAS can target burnt flares on the Almayer (shipside)
2 participants