Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug that would jam guns entirely #6470

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

GrrrKitten
Copy link
Contributor

@GrrrKitten GrrrKitten commented Jun 15, 2024

About the pull request

I couldn't figure out what caused this bug but it was getting kinda bad, something about alternating akimbo would cause guns to be entirely disabled, with the current_mag having been ejected, but still marked as in the gun, but not in the contents, meaning the gun was entirely broke as you couldnt clear out the mag inside of it cause there was no mag.

this pr just adds a failsafe to prevent this from ever happening

Explain why it's good for the game

Having your gun becoming entirely unusable and having to just toss it out cause a bug broke it isnt fun

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: fixes a bug that fully jammed guns being used in akimbo
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 15, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as much as i hate failsafes to catch conditions that we should just not allow to happen, it's fine

@harryob harryob added this pull request to the merge queue Jun 16, 2024
Merged via the queue into cmss13-devs:master with commit 5725cd2 Jun 16, 2024
28 of 30 checks passed
cm13-github added a commit that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants